Create a new type of Asset called 'TargetableAsset' #476
Conversation
…ssociated with them With the state file supplying asset values instead of them being generated, the cluster 'Asset' is not sufficient to describe that it is a special kind of target. In this commit, the 'Cluster' WritableAsset is now a TargetableAsset, which has a special meaning - they will have an 'Apply' function that will be executed irrespective of whether 'Generate' is called upon the asset or not.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rajatchopra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
size/M
|
/close There is no distinction between an asset which is targeted and one that is not. |
|
@crawford: Closing this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I perhaps mean to suggest that some assets/targets have actions associated over and above stuff that is written/persisted to disk e.g. 'cluster' actually creates the cluster and not just dump manifest/tfvars. Did you just not like the name 'TargetableAsset' here? |
|
We already have a generate method. This contains all of the functionality needed to create that particular asset. There shouldn't be a separate process for some assets. |
That not exactly correct, the cluster asset is not just dumping tfvars, tfstate. metadata.json etc... it is creating the cluster to generate them. |
4 participants
Meant for those targets (e.g. cluster) that have an action associated with them. 'Cluster' as a WritableAsset does not cover its intent.
This PR is a proposed fix for the issue raised by @wking in this comment.
With the state file supplying asset values instead of them being generated, the cluster 'Asset' is not sufficient to describe that it is a special kind of target.
In this commit, the 'Cluster' WritableAsset is now a TargetableAsset, which has a special meaning - they will have an 'Apply' function that will be executed irrespective of whether 'Generate' is called upon the asset or not.